Fix polars Q29 regex semantics to match REGEXP_REPLACE#978
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
wudidapaopao
changed the title
rschu1ze
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polars translation of Q29 used
str.extract, which returns null when the regex does not match, whileREGEXP_REPLACE(Referer, pattern, '\1')used by other systems keeps the original string for non-matching rows. This semantic inconsistency may give polars a potential performance benefit on this query.This replaces
str.extract(pattern)withstr.replace(pattern, '${1}'), which has the same semantics asREGEXP_REPLACE: the matched string is replaced by capture group 1, and non-matching strings are returned unchanged.