Skip to content

Nuke this: click anything away, remembered per site and per service (2.1.0) - #14

Merged
ccmrik merged 1 commit into
mainfrom
nuke-this
Nov 16, 2026
Merged

ccmrik merged 1 commit into
mainfrom
nuke-this

Conversation

@ccmrik

@ccmrik ccmrik commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

What

"Nuke this" replaces "Kill nag wall" in the popup.

  • Picker: hover highlights, click hides, Esc cancels. Clicking inside a full-screen overlay takes the whole overlay, dimmer included. The page never gets the click. Scroll locks and blur are undone.
  • Per site: the pick is saved and applied as user-origin CSS on every visit, so it beats the page's own inline !important.
  • Per service: if the element's class or id is named after a third-party script host on the page (.pelcro-* with js.pelcro.com), the service is learned and its overlay is hidden on every other site showing the token. Shared platforms (Google, Cloudflare, CDNs and so on) are never learned.
  • Undo: on-page toast (straight after), popup (per site), and a new "Nuked" card in Settings (sites and services).
  • The nag-wall sweep still runs when Nuke is pressed. "Always on this site" is now "Auto-kill nag walls here".

Trust

The picker is the only content script that can change settings. background/nuke.js accepts a save only from the top frame of a tab the popup armed (10 min), one save per arm, and undo only for that save (60 s). Selectors are limited to the grammar the picker writes (escaped idents, # . >, :nth-of-type(n)), so nothing can close a rule. Service tokens must be plain identifiers.

Tests

  • test/unit/nuke.test.mjs: selector and token validation, service learning (Pelcro case, denylist, own-site, short brands), CSS output, normalisation.
  • test/e2e/nuke.spec.mjs: one-click overlay nuke, reload persistence, learned service on a second site, Esc, undo, arming, popup Undo, Settings removal. Mutation-checked: disabling service matching or the arm check fails the right tests.
  • Full npm run check: 42 unit, 60 e2e. One unidentified flake in the first of four full runs; three clean runs since, and the nuke spec passed 30/30 under --repeat-each=5.
  • Firefox smoke 6/6. The picker itself is not covered in Firefox (Selenium can't open the popup).

🤖 Generated with Claude Code

…2.1.0)

"Nuke this" replaces "Kill nag wall" in the popup. It sweeps for anti-adblock
walls as before, then drops a picker on the page: hover highlights, click
hides, Esc cancels. Clicking inside a full-screen overlay takes the whole
overlay. Scroll locks and blur are undone.

The pick is saved for the site and applied as user-origin CSS on every visit.
When the element is named after a third-party script host on the page
(.pelcro-* with js.pelcro.com), the service is learned and its overlay is
hidden on any other site that shows the token. Shared platforms are never
learned.

The picker is the only content script that can change settings: the worker
takes a save only from the top frame of a tab the popup armed, one save per
arm, and validates selectors and tokens in shared/nuke-rules.js.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccmrik
ccmrik merged commit 260636f into main Nov 16, 2026
1 check passed
@ccmrik
ccmrik deleted the nuke-this branch November 16, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant