Fileuploader fixed - #124
Merged
Merged
Conversation
Copilot started reviewing on behalf of
veronika-tseleva-cleantalk
August 21, 2026 11:32
View session
There was a problem hiding this comment.
Pull request overview
This PR adjusts the screenshot-capture logic in FileUploader (dom-to-image/html2canvas path) to address viewport sizing issues by moving sizing control into html2canvas’s onclone hook, and updates the distributed bundles accordingly.
Changes:
- Tweaks the dom-to-image blob-size check formatting (no functional change).
- Replaces
html2canvaswindowWidth/windowHeightoptions with explicit cloned-document sizing inonclone. - Regenerates
dist/bundles to include the updated screenshot logic.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| js/src/fileuploader.js | Updates html2canvas screenshot cloning/sizing behavior. |
| dist/doboard-widget-bundle.js | Built bundle updated with the same screenshot changes. |
| dist/doboard-widget-bundle.min.js | Minified bundle updated with the same screenshot changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+502
to
+506
| clonedDoc.documentElement.style.width = window.innerWidth + 'px'; | ||
| clonedDoc.documentElement.style.height = window.innerHeight + 'px'; | ||
| clonedDoc.body.style.width = window.innerWidth + 'px'; | ||
| clonedDoc.body.style.height = window.innerHeight + 'px'; | ||
| clonedDoc.body.style.minHeight = window.innerHeight + 'px'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.