fileuploader fixed - #123
Merged
Merged
Conversation
Copilot started reviewing on behalf of
veronika-tseleva-cleantalk
August 21, 2026 11:10
View session
There was a problem hiding this comment.
Pull request overview
Updates the screenshot/upload flow in FileUploader.makeScreenshot() to better handle cross-origin stylesheet (CORS) issues by detecting CSS access errors up front and favoring the html2canvas fallback when needed.
Changes:
- Detects
SecurityErrorwhen readingdocument.styleSheets[i].cssRulesand skipsdom-to-imagewhen cross-origin CSS is present. - Improves
dom-to-imageerror logging and adds a small-blob guard to treat near-empty results as failures. - Propagates the same logic into the distributed (bundled/minified) artifacts.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js/src/fileuploader.js | Adds stylesheet CORS detection, adjusts dom-to-image execution/handling, and preserves html2canvas fallback behavior. |
| dist/doboard-widget-bundle.js | Rebuilt bundle reflecting the updated screenshot logic. |
| dist/doboard-widget-bundle.min.js | Rebuilt minified bundle reflecting the updated screenshot logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+473
to
475
| if (blob && blob.size < 100) { | ||
| blob = null; | ||
| } |
Comment on lines
+437
to
+439
| try { | ||
| const rules = document.styleSheets[i].cssRules; | ||
| } catch (e) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.