Skip to content

fileuploader fixed #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veronika-tseleva-cleantalk merged 1 commit into from
Aug 21, 2026
Merged

fileuploader fixed #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions dist/doboard-widget-bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13827,6 +13827,8 @@ class FileUploader {
let bgColor = window.getComputedStyle(document.body).backgroundColor;
if (bgColor === 'rgba(0, 0, 0, 0)' || bgColor === 'transparent') bgColor = '#ffffff';

const currentOrigin = window.location.origin;

try {
const domtoimageLib = await this.loadDomToImage();
if (domtoimageLib) {
Expand All @@ -13840,7 +13842,25 @@ class FileUploader {
},
filter: (node) => {
if (node.classList && node.classList.contains('doboard_task_widget')) return false;
if (node.tagName === 'NOSCRIPT') return false;
if (node.tagName === 'NOSCRIPT' || node.tagName === 'IFRAME') return false;

if (node.tagName === 'IMG' && node.src && node.src.startsWith('http')) {
try {
const url = new URL(node.src);
if (url.origin !== currentOrigin && !node.crossOrigin) return false;
} catch (e) {
return false;
}
}

if (node.tagName === 'LINK' && node.rel === 'stylesheet') {
try {
if (node.sheet && !node.sheet.cssRules) return false;
} catch (e) {
return false;
}
}

return true;
}
});
Expand Down Expand Up @@ -13869,7 +13889,6 @@ class FileUploader {
windowWidth: document.documentElement.offsetWidth,
windowHeight: document.documentElement.offsetHeight,
onclone: (clonedDoc) => {
const currentOrigin = window.location.origin;
const transparentPixel = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7';

clonedDoc.querySelectorAll('img').forEach(img => {
Expand Down
2 changes: 1 addition & 1 deletion dist/doboard-widget-bundle.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/doboard-widget-bundle.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 21 additions & 2 deletions js/src/fileuploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,8 @@ class FileUploader {
let bgColor = window.getComputedStyle(document.body).backgroundColor;
if (bgColor === 'rgba(0, 0, 0, 0)' || bgColor === 'transparent') bgColor = '#ffffff';

const currentOrigin = window.location.origin;

try {
const domtoimageLib = await this.loadDomToImage();
if (domtoimageLib) {
Expand All @@ -443,7 +445,25 @@ class FileUploader {
},
filter: (node) => {
if (node.classList && node.classList.contains('doboard_task_widget')) return false;
if (node.tagName === 'NOSCRIPT') return false;
if (node.tagName === 'NOSCRIPT' || node.tagName === 'IFRAME') return false;

if (node.tagName === 'IMG' && node.src && node.src.startsWith('http')) {
try {
const url = new URL(node.src);
if (url.origin !== currentOrigin && !node.crossOrigin) return false;
Comment on lines +450 to +453
} catch (e) {
return false;
}
}

if (node.tagName === 'LINK' && node.rel === 'stylesheet') {
try {
if (node.sheet && !node.sheet.cssRules) return false;
} catch (e) {
return false;
}
}

return true;
}
});
Expand Down Expand Up @@ -472,7 +492,6 @@ class FileUploader {
windowWidth: document.documentElement.offsetWidth,
windowHeight: document.documentElement.offsetHeight,
onclone: (clonedDoc) => {
const currentOrigin = window.location.origin;
const transparentPixel = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7';

clonedDoc.querySelectorAll('img').forEach(img => {
Expand Down