fix(admin): stop browser autofilling credential Label/API key as login (CLEAN-46) - #42
Merged
Merged
Conversation
…n (CLEAN-46) Chrome ignores autocomplete="off" on password inputs and pairs the API key field with the nearest text input (Label) as a username/password form, injecting saved credentials. new-password on the key input plus off + non-suggestive names on the label/form break the heuristic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type="password"withautocomplete="off", which Chrome ignores on password fields — it pairs the field with the nearest preceding text input (Label) as username/password.autocomplete="new-password"on the API key input (respected by Chrome),autocomplete="off"+ non-suggestivenameattrs on the Label input and the form. Shareditem/Form.vuecovers both create and edit pages.Test plan
🤖 Generated with Claude Code