ci: provider suite becomes a gate; PR gate checks dev's head - #197
Merged
Merged
Conversation
Provider functional ran report-only while it was flaky against dev. After the sidebar, autosave and upload fixes in CivicDataSpace-test, three full provider runs passed with no retries, so a provider failure now rolls back the deploy like any other functional failure.
It ran as a separate report-only job that branch protection ignored. Folding it into Full Suite makes a provider failure block the release PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider suite is now a gate (was report-only while flaky against dev):
functional-tests, so a provider failure rolls back like any other functional failure. The separate report-only job is removed from rollback/finalize.Evidence it's stable: after CivicDataSpace-test #84 and #87, three full provider runs against dev (35187299207, 35188575284, 35189909052) each passed 12/12 with no retries.
Deployed-SHA check uses dev's head (fixes #195): it compared dev's live
git_shaagainst the PR head, so any release PR built as a merge commit failed by construction (#191). A smalldev-headjob resolves dev's tip and Full Suite checks against that.Three commits, one per change. Both workflow files parse.