Release: fix stale search results after publishing - #194
Merged
Merged
Conversation
It was set with the cache's default 300s timeout, so it fell back to 0 while results stayed cached for 3600s, making results cached under an earlier version 0 reachable again. One helper now owns the key and the bump.
The bump ran before the Elasticsearch write, so a search in that gap cached the old total under the new version for an hour. Sitemap and search then disagreed and the prod read-only check rolled back a deploy.
fix: stale search results after publishing
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes #192 to prod (fixed in #193).
What ships (7 files vs main): search cache invalidation now runs after a refreshed Elasticsearch write, and its version key never expires. Applies to datasets, use cases and collaboratives, plus
tests/test_search_cache_invalidation.py.Why it matters for prod: a stale search total failed the prod read-only sitemap check on frontend deploy 35085603469 and rolled it back.
Verified:
dataset_datastays reverted on main — unchanged by this release.Merge with Create a merge commit, not rebase.