fix: repair broken PR gate; give report-only provider jobs the Keycloak secret - #183
Merged
Merged
Conversation
org_add_permission needs a Keycloak token to check canAdd. A called workflow only sees secrets its caller passes, and the report-only job passed none, so every org-create test skipped on both workers -- the provider report looked green while never exercising org flows.
…t to provider-report
Two CodeQL autofix commits each added a top-level permissions block
(permissions: {} and contents/pull-requests: read). A duplicate key is
invalid YAML, so GitHub rejected the workflow and the PR gate never ran.
Keeps the least-privilege read block. Also passes KEYCLOAK_CLIENT_SECRET
to provider-report, whose org-create tests otherwise all skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report-only provider jobs passed no
KEYCLOAK_CLIENT_SECRET. A called workflow only sees secrets its caller passes, soorg_add_permissioncouldn't get a token and every org-create test skipped on both workers — e.g. a green provider report was7 passed, 5 skipped, the 5 being all org flows. Adds the secret andapi_base_urlto the deploy workflow'sprovider-functional-reportand the PR gate'sprovider-report.Also fixes a broken PR gate on main: two CodeQL autofix commits each added a top-level
permissions:block ({}andcontents/pull-requests: read). Duplicate keys are invalid YAML, so GitHub rejectedpr-gate.ymland every run since has failed with no jobs. Keeps the least-privilege read block.