feat: deploy gating model — two-stage dev, readonly prod, PR gate - #179
Merged
Merged
Conversation
dev: smoke first; functional runs only if smoke passes; either failing rolls back, both passing finalizes. main: only the readonly allowlist runs against prod (provider never), replacing skip_provider. Finalize uses !failure() because functional-tests is skipped on main by design.
Runs the full suite (smoke, functional, regression) against dev on every PR into main. deployed_sha is the PR head, so the gate fails unless dev is running exactly the code being merged.
Provider functional tests fail at shifting points against dev (autosave races, slow create flows), so gating on them would roll back dev deploys spuriously. The gating functional stage and the PR gate now skip provider; separate provider jobs run with only_provider and report, without being a dependency of rollback/promote or a required check.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Finalize and rollback did not list the report-only provider job in needs, so a deploy asked for finalize approval while provider tests were still running. Both now wait for it, and condition on the gating jobs' results explicitly instead of failure()/!failure(), which would count the report-only job's result.
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy gating model for DataSpaceBackend:
readonlyallowlist runs against prod (112 audited tests, provider never) → rollback or finalize.pr-gate.yml): every PR intomainruns the full suite (smoke + functional + regression) against dev, withdeployed_sha= PR head, so it fails unless dev is running exactly the code being merged. Provider reports separately and won't be a required check.Uses CivicDataSpace-test's new
suite/only_providerinputs (#76, #78).Note: this PR is not a dev→main PR, so the new PR gate on it is expected to fail its deployed-SHA check (dev isn't running this branch) — a live check that the gate rejects non-dev code. Branch protection isn't enabled yet, so it won't block.