fix: point prod smoke tests at prod and skip provider-smoke there - #175
Merged
Conversation
The Smoke Tests job passed the repo-level HOME_URL_DEV (the dev site) on main too, so every prod deploy's consumer and provider suites tested dev: prod's nginx logged 0 test-browser requests during a prod run's smoke window, dev's logged 8840. Prod rollbacks were being triggered by dev timeouts, and prod's UI was never actually tested. On main, pass the prod URL and set skip_provider, since provider-smoke creates content with the test account.
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Smoke Tests job passed the repo-level
HOME_URL_DEV(the dev site) onmaintoo, so every prod deploy's consumer and provider suites tested dev. During one prod run's smoke window, prod's nginx logged 0 test-browser requests and dev's logged 8,840. Today's prod rollbacks were triggered by dev-host timeouts; prod's UI was never tested.On
main: pass the prod URL (a literal, so a missing secret can't silently fall back to dev through the&& ||idiom) and setskip_provider, since provider-smoke creates content with the test account. Depends on CivicDataSpace-test#54 (merged) and #55.Validated locally against prod with the updated suite: api-smoke 27 passed; consumer-smoke failures were all dev-specific assumptions, fixed in #55.