fix: register debug_toolbar in INSTALLED_APPS (dev companion to #161) - #162
Merged
Conversation
MIDDLEWARE conditionally added debug_toolbar's middleware when DEBUG is True, but INSTALLED_APPS never registered the app itself -- git history shows this pairing existed before and the INSTALLED_APPS half got dropped somewhere along this repo's messy merge/revert history. Broke every build since (confirmed via 3 failed CI runs today, all at the same step): the sanity-check step's `manage.py check` runs with DEBUG defaulting to True (no DEBUG env var set), and any request/check path that touches debug_toolbar's models crashes with "Model class debug_toolbar.models.HistoryEntry doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS" -- the middleware imports the app's models without the app being registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #161 — same commit, cherry-picked onto `dev`. See #161 for full rationale.