feat: add a readonly marker as the allowlist for production runs - #75
Merged
Conversation
Only tests marked readonly may run against production. It is opt-in per file, so a new test never reaches prod by default. Applied to the 16 files under tests/api/smoke and tests/consumer/smoke after auditing each for writes: they browse, query, or log in with the existing test account and read. The known writers -- dataset create/delete mutations in tests/api/functional and account creation in tests/consumer/functional -- are not marked. -m readonly selects 112 tests: exactly those files, none from functional/, mobile/ or provider/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1a of the deploy gating plan: only tests marked
readonlymay run against production. Opt-in per file (default-deny), so new tests never reach prod unless someone consciously marks them.Applied to the 16 files under
tests/api/smokeandtests/consumer/smoke, each audited for writes — they browse, query, or log in with the existing test account and read. Not marked: dataset create/delete mutations (tests/api/functional) and account creation (tests/consumer/functional).pytest -m readonly --collect-only: 112 tests — exactly those files; 0 fromfunctional/,mobile/,provider/. Metadata only; no behavior change until the workflow selects on it (next PR).