fix: test_auth_token_has_required_fields never ran (bring main's fix to CI) - #72
Merged
Merged
Conversation
Missing client_secret on the ROPC call 401'd against the confidential client and the old skip-on-401 swallowed it silently.
saqibmanan
force-pushed
the
fix/auth-token-test-client-secret
branch
from
September 11, 2026 17:22
9acdd1f to
59ed1d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39. Cherry-pick of c0bbc21, already on
mainbut never onCI— the branch every deploy pipeline consumes. The ROPC call omittedclient_secret, Keycloak 401'd the confidential client, and the helper turned 401 into a skip.Validated against dev:
test_auth_token_has_required_fields PASSED(was SKIPPED). Note: it'sfunctional, so this PR's own CI (smoke-only on pull_request) won't exercise it — that selection gap is #70.