Skip to content

fix: revive TC_HOM_02-09, hidden in a string literal since written - #71

Merged
saqibmanan merged 1 commit into
CIfrom
fix/revive-hidden-homepage-tests
Sep 11, 2026
Merged

fix: revive TC_HOM_02-09, hidden in a string literal since written#71
saqibmanan merged 1 commit into
CIfrom
fix/revive-hidden-homepage-tests

Conversation

@saqibmanan

Copy link
Copy Markdown
Contributor

Closes #38 (the TC_HOM_02–09 block; the second hidden block is split out as its own card).

A stray ''' swallowed TC_HOM_02–09, so they never ran. Reviving them needed:

  • *Locators.X unpacking — they passed By.XPATH plus an already-(By, str) tuple
  • the smoke marker CI selects on
  • current locators: 5 of 8 no longer matched the redesigned homepage

Retargeted: TC_HOM_04 → the search box's own Search button (header button is gone); TC_HOM_07 → footer About Us link. TC_HOM_08 removed — no sitemap link exists anywhere; footer links are covered by 07/09/15. TC_HOM_02 waits for the lazy-loaded 1.5MB hero SVG to finish loading instead of racing it.

Validated: whole test_components.py, smoke or functional — dev 19 passed, prod 19 passed (read-only homepage checks).

A stray ''' swallowed TC_HOM_02 through TC_HOM_09, so they never ran.
Revived, they also needed: *Locators unpacking (they passed By.XPATH
plus an already-(By, str) tuple), the smoke marker CI selects on, and
current locators -- five of eight no longer matched the redesigned
homepage. TC_HOM_04 now targets the search box's own Search button
(the header one is gone); TC_HOM_07 the footer About Us link; TC_HOM_08
is removed (no sitemap link exists; footer links are covered by 07/09/15).
TC_HOM_02 waits for the lazy-loaded 1.5MB hero SVG to finish loading.

Refs #38.
@saqibmanan
saqibmanan merged commit 9897cd7 into CI Sep 11, 2026
3 checks passed
@saqibmanan
saqibmanan deleted the fix/revive-hidden-homepage-tests branch September 11, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant