fix: run prod GA checks when the suite targets prod - #66
Merged
Merged
Conversation
The reusable smoke workflow only passes HOME_URL_DEV (the target site), never HOME_URL_PROD, so on prod deploys all four test_prod_* GA checks skipped and the two dev checks skipped too: zero GA coverage. When the target isn't a dev host, the prod checks now run against it. Closes #64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64. The reusable workflow only passes
HOME_URL_DEV(the target site), neverHOME_URL_PROD, so on prod deploys all 4test_prod_*GA checks skipped — and the 2 dev checks correctly skip there too: zero GA coverage on prod.When the target host isn't a dev host,
PROD_URLnow falls back to it. No workflow or secret change.Validated with
HOME_URL_PRODempty (as in CI):