fix: make consumer-smoke correct when pointed at prod - #55
Merged
Merged
Conversation
HOME_URL_DEV is whichever site the suite targets. Pointed at prod, the two dev GA tests asserted GA is absent on prod, where it is correctly present (G-41CT4XZ341). They now skip unless the host starts with dev., matching the contract stated in the file header.
A React re-render between wait_and_capture returning an element and the caller's is_displayed() leaves a stale reference -- a race, not a logic failure, and the same shape across ~43 wait_and_capture callers. Seen on test_TC_SEC_02_search_bar against prod.
saqibmanan
force-pushed
the
fix/consumer-suite-prod-target
branch
from
September 11, 2026 13:22
d822de8 to
60e9935
Compare
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consumer-smoke had only ever targeted dev. Run against prod:
3 failed, 42 passed, none a prod-site problem.test_dev_ga_script_tag_absent,test_dev_gtag_is_undefined) asserted GA is absent on prod, where it's correctly present. They now skip unless the target host starts withdev.. Verified: vs dev 6 passed; vs prod 4 passed + 2 skipped.test_TC_SEC_02_search_barhitStaleElementReferenceException— React re-rendered betweenwait_and_capturereturning the element and the caller'sis_displayed(). Added it to the rerun policy's timing signatures (same pattern across ~43 callers).