fix: allow 30s for waits that depend on a backend round-trip - #53
Merged
Merged
Conversation
The post-create Metadata-tab wait (10s) and select_combobox_option's option wait (default 15s) both wait on the backend: a create mutation plus navigation, or an option list populated by a GraphQL query on page load. select_sdg_goals already allows 30s for exactly this kind of option list. Both timed out repeatedly in deploy-pipeline smoke runs while the target host was under concurrent load from three suites.
saqibmanan
added a commit
that referenced
this pull request
Sep 11, 2026
…ess (#56) * fix: allow 30s for waits that depend on a backend round-trip (#53) The post-create Metadata-tab wait (10s) and select_combobox_option's option wait (default 15s) both wait on the backend: a create mutation plus navigation, or an option list populated by a GraphQL query on page load. select_sdg_goals already allows 30s for exactly this kind of option list. Both timed out repeatedly in deploy-pipeline smoke runs while the target host was under concurrent load from three suites. * fix: skip dev-only GA-absent checks when the target isn't a dev host HOME_URL_DEV is whichever site the suite targets. Pointed at prod, the two dev GA tests asserted GA is absent on prod, where it is correctly present (G-41CT4XZ341). They now skip unless the host starts with dev., matching the contract stated in the file header. * fix: rerun on StaleElementReferenceException as a timing signature A React re-render between wait_and_capture returning an element and the caller's is_displayed() leaves a stale reference -- a race, not a logic failure, and the same shape across ~43 wait_and_capture callers. Seen on test_TC_SEC_02_search_bar against prod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-create Metadata-tab wait (10s, 4 places) and
select_combobox_option's option wait (default 15s) both wait on the backend — a create mutation plus navigation, or an option list populated by a GraphQL query.select_sdg_goalsalready allows 30s for the same kind of option list.These timed out repeatedly in deploy-pipeline smoke runs while the target host was under load from three concurrent suites. Validated locally: full provider-smoke against dev, run concurrently with api and consumer suites,
12 passed, 1 xfailed, 1 xpassed, zero reruns — test_prv_002b/006/006b all passed first try.