fix: scope SDG Goals and Geography locators to combobox role - #51
Merged
Merged
Conversation
TAGS_INPUT and SECTOR_INPUT in the same file already scope their following::input search to [@ROLE='combobox'], but SDG_GOALS_CONTAINER and GEOGRAPHY_CONTAINER were never updated to match -- both still used the bare unscoped following::input[1], which can grab any intervening non-combobox input (date pickers, file uploads, etc.) depending on render timing/DOM state. This is exactly the aliasing class of bug get_pill_texts() was already hardened against (see its docstring) -- but that only helps once the input locator itself is correct. Reproduced live: a real deploy run's smoke test read back 'Budget' as the selected SDG goal instead of the requested '13' (Climate Action) -- prod's actual SDG data is fully correct (verified directly), confirming the wrong <input> was targeted, not a data issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TAGS_INPUT/SECTOR_INPUT already scope their
following::inputsearch to[@role='combobox']; SDG_GOALS_CONTAINER and GEOGRAPHY_CONTAINER never got the same fix and still use the bare, unscopedfollowing::input[1]-- which can grab the wrong field's input depending on render timing/DOM order.Reproduced live: a real prod deploy's smoke test read back "Budget" as the selected SDG goal instead of the requested "13" (Climate Action). Verified prod's actual SDG table is correct (all 17 standard UN goals) -- confirming this was the test targeting the wrong element, not a data/app bug.
Verified fix passes against dev.