Validate source-storage quotas before API startup - #2884
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Bounded independent Luna review found no concrete API configuration-binding defect. All eleven focused cases and the full backend suite pass (9,197 passed, 34 existing skips). API/MCP host-start validation and CLI resolve-time validation are distinguished in the description. No high/critical findings; hosted exact-head checks remain the merge gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-storage quotas now bind through validated shared options, and the byte store receives that same settings instance. Zero or negative limits fail API startup with the relevant setting name, before an upload can turn a deployment mistake into a server error. Default and large valid limits remain supported; the byte store retains runtime checks for directly constructed settings.
Continues #2808 and addresses hosted comment3975016187; stacked on #2866.
Verification: eleven targeted tests pass, covering eight zero/negative cases, default/large limits, DI instance identity and a real API boot failure before upload. Full backend
dotnet test backend/Taskdeck.sln -c Release -m:1passed 9,197 tests with 34 existing skips (Domain 1,639; Application 4,258; API 3,022; CLI 243; Architecture 28; Integration 7). Documentation links/governance/diff pass. One bounded independent Luna review found no API configuration-binding defect. The first standalone DI fixture omitted the standard synthetic connector encryption key; it now supplies that test prerequisite. No real credentials were used.There is no frontend change. API/MCP hosts start their host and execute startup validation; the CLI currently builds without starting, so these options are validated when resolved there. This does not claim every CLI command validates unused storage settings at launch. Production configuration/physical-device acceptance and existing OUTSTANDING_TASKS.md human choices remain separate.