Retract original selections when memory revisions conflict - #2883
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Independent bounded Luna review is CLEAN. The current-generation409 retracts originals and selection; subsequent refresh/reselection uses the new revision, with server enforcement unchanged. Full proving results are recorded in the PR body. |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original-source picker now retracts displayed choices and selected originals when pagination returns a memory-revision conflict, then gives explicit source-refresh guidance. A selected original can no longer remain attached to an outgoing turn after that failed page request. Server revision/hash enforcement remains unchanged.
Continues #2808 and addresses hosted comment3975016183. Stacked on #2879; preserve the comparison/integration bases until they land.
Verification: thirteen targeted component tests; full frontend 6,378 passed/3 existing skips across 412 files; production build/typecheck, scoped ESLint and documentation links/governance/diff pass. Real-API Chromium passes in 17.6 seconds: concurrent revision12-to13 update, actual409 pagination, clear/refresh/reselect, outgoing revision13 context, receipt replay across all four experiences,403 recovery and375px accessibility. One bounded independent Luna review is CLEAN. Temporary services are stopped; only synthetic data was used.
No implicit retrieval, automatic send, provider call or backend authority change. Physical devices, production release and existing OUTSTANDING_TASKS.md human choices remain separate.