-
Notifications
You must be signed in to change notification settings - Fork 0
perf(ci): isolate launcher evidence from frontend qualification #2867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e66711b
perf(ci): isolate Linux launcher qualification from frontend semantics
Chris0Jeky 3f52e9b
fix(ci): preserve fail-closed path coverage and nightly mappings
Chris0Jeky c959c83
Merge branch 'codex/2336-staging-review' into codex/2336-launcher-review
Chris0Jeky 97a0dde
Merge branch 'main' into ci/continuation-04-launcher
Chris0Jeky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Source-launcher and frontend verification boundaries | ||
|
|
||
| Date: 2026-09-10. Owners: #2331, #2332 and #2329. Parent: [engineering contract](README.md). | ||
|
|
||
| `reusable-frontend-unit.yml` defines two independent job families. `source-launcher` runs the existing regression once on hosted Linux; `frontend-unit` retains the complete Linux/Windows matrix and every previous frontend semantic check. No launcher source or test implementation is changed. | ||
|
|
||
| The exact launcher command remains `node --test --test-concurrency=1 --test-timeout=30000 scripts/ci/dev-up.test.mjs`. Its Linux guard and ten-minute step timeout are unchanged. The separate job has a fifteen-minute ceiling for checkout/Node setup around the suite's own watchdog. Node uses the caller's version input. The new checkout disables credential persistence; preserve concurrent checkout hardening during integration. PowerShell cases remain governed by SC-3; this slice does not change #2858's cleanup implementation. | ||
|
|
||
| ## Independent results without lost qualification | ||
|
|
||
| Previously a launcher failure stopped the Linux frontend job before lint/typecheck/build/coverage, and backend changes affected that mixed job's input identity. Sibling jobs can finish independently. A launcher failure still fails the reusable call/E2E prerequisite; it does not erase an independently successful frontend result. The caller's `needs: frontend-unit` waits for both families. | ||
|
|
||
| Parallelism introduces one extra job's setup/rounding overhead. No measured savings are claimed. Full frontend coverage stays full; no partial threshold is substituted. | ||
|
|
||
| ## Canonical and historical accounting | ||
|
|
||
| The existing shadow policy gains `source-launcher-linux`, context `Frontend Unit / Source Launcher (Linux)`, using hosted Linux. Its ownership is added to fifteen existing backend/frontend/launcher/script groups, without changing ANY existing group ID, path pattern or risk floor. Unknown paths therefore retain their original escalation and nightly suite mapping remains valid. No required check is registered. | ||
|
|
||
| The adapter gives the new lane the backend/frontend/script closure. Post-split frontend fingerprints no longer depend on backend sources. Historical policies without the new lane retain the original broad compound-job contract; old evidence is not reinterpreted retroactively. All Taskdeck contracts remain unreviewed/reuse-disabled. | ||
|
|
||
| Original policy blob: `8fc840fac37bef19790e3b4ec6e03280ea5c81ee`. Removing the new lane and its existing-group references reconstructs the original parsed policy exactly. Canonical receipt schema versions are unchanged. | ||
|
|
||
| ## Hosted integration correction | ||
|
|
||
| The first hosted head `e66711b3` exposed nine self-test failures: a broad new ownership group lacked a nightly mapping and changed an overlap fixture; an inherited E2E test forbade the newly intended frontend barrier. The correction removes the broad group rather than weakening the nightly validator, inherits only existing ownership, and incorporates the parent E2E contract correction. Earlier failures remain recorded. Fresh hosted qualification is required. | ||
|
|
||
| Local continuation plus launcher-placement tests originally passed 264/264 on Node 22.16.0/Linux, but that was not the complete existing Smart CI suite. The corrected local overlay, including in-progress provider tests, passes 309/309; the same local limitations remain. The actual product launcher/frontend suites, full hosted self-tests, independent review and maintainer review are still required. Do not claim earlier fixture success qualified the failed hosted head. | ||
|
|
||
| ## Rollback | ||
|
|
||
| Restore the original launcher step when removing the separate job; never remove the new job alone. Remove its lane and existing-group references, and restore the broad adapter contract together. Preserve concurrent launcher fixes/credential hardening. Canonical coordinator-owned documents are left unchanged; reconcile their topology prose with this scoped record after the stack lands. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.