Skip to content

Announce unavailable Review results without moving focus - #2859

Open
Chris0Jeky wants to merge 2 commits into
mainfrom
issue-2215/unavailable-announcement
Open

Announce unavailable Review results without moving focus#2859
Chris0Jeky wants to merge 2 commits into
mainfrom
issue-2215/unavailable-announcement

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

A delayed unavailable-proposal lookup can preserve focus in the queue or a batch approval dialog but settle silently. Add a persistent polite status region using the existing localized unavailable/malformed message and return action. Capture which surface owns the result so the modal announces inside its own subtree, polling does not repeat it, and cancelling the dialog does not replay it in the queue.

Verification:

  • Baseline: two new announcement expectations failed; four existing focus cases passed. Fixed focused mounted/dialog coverage:9passed.
  • Full frontend run:6287passed/3skipped/2failed. The two failures were existing exact-child-list expectations missing the added status node. A test-only follow-up updates those lists and verifies the node remains outside grid flow; all223 tests in the affected three specs then passed. No production logic changed after independent review or browser proof.
  • Typecheck, scoped ESLint and production build passed. Synthetic Chromium delayed-lookup check passed1/1 (30.5s), using isolated ports5551/5851 and Mock provider; screenshot inspected. It verifies the persistent status text, preserved focus, and clearing on Return.
  • Independent Terra high review: SHIP, no HIGH/CRITICAL blocker. Hosted CI must qualify the final head.

This proves DOM live-region semantics and focus behavior; no actual screen-reader announcement or subjective AT acceptance is claimed. Review-first actions and authorization are unchanged.

Refs #2215.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T23:06:59.126671Z 538fd3c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent Terra high review: SHIP, no causal HIGH/CRITICAL blocker. Each result retains one announcement owner; a fresh lookup clears it, polling the same unavailable ID does not repeat it, and cancelling an owning batch dialog leaves the root status silent. Reviewer did not run tests. The later538fd3cf3 commit changes only two structural test expectations for the added node; affected specs passed223/223, and final typecheck/scoped lint passed.

Synthetic Chromium passed1/1 on the unchanged production implementation, screenshot inspected. Full pre-test-fix suite had6287pass/3skip/2 structural-expectation failures; the scoped pass resolves those two, without claiming a second full run. Hosted required34415015951 is running at final538fd3cf370d2a408729c8954e8e2835d5576d73.

Sixteen evidence files (logs, synthetic database, browser result/screenshot) were copied and hash-verified to .claude/local/milestone-20260909/preserved-2215-announcement before plain worktree removal. Both owned browser ports are closed; all owned test sessions are terminal. No actual screen-reader output was verified. OUTSTANDING_TASKS.md remains unchanged.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 538fd3cf37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/views/paper/PaperReviewView.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

1 participant