Announce unavailable Review results without moving focus - #2859
Announce unavailable Review results without moving focus#2859Chris0Jeky wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra high review: SHIP, no causal HIGH/CRITICAL blocker. Each result retains one announcement owner; a fresh lookup clears it, polling the same unavailable ID does not repeat it, and cancelling an owning batch dialog leaves the root status silent. Reviewer did not run tests. The later538fd3cf3 commit changes only two structural test expectations for the added node; affected specs passed223/223, and final typecheck/scoped lint passed. Synthetic Chromium passed1/1 on the unchanged production implementation, screenshot inspected. Full pre-test-fix suite had6287pass/3skip/2 structural-expectation failures; the scoped pass resolves those two, without claiming a second full run. Hosted required34415015951 is running at final538fd3cf370d2a408729c8954e8e2835d5576d73. Sixteen evidence files (logs, synthetic database, browser result/screenshot) were copied and hash-verified to .claude/local/milestone-20260909/preserved-2215-announcement before plain worktree removal. Both owned browser ports are closed; all owned test sessions are terminal. No actual screen-reader output was verified. OUTSTANDING_TASKS.md remains unchanged. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 538fd3cf37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A delayed unavailable-proposal lookup can preserve focus in the queue or a batch approval dialog but settle silently. Add a persistent polite status region using the existing localized unavailable/malformed message and return action. Capture which surface owns the result so the modal announces inside its own subtree, polling does not repeat it, and cancelling the dialog does not replay it in the queue.
Verification:
This proves DOM live-region semantics and focus behavior; no actual screen-reader announcement or subjective AT acceptance is claimed. Review-first actions and authorization are unchanged.
Refs #2215.