Isolate manual webhook resilience claims from hosted workers - #2854
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Terra independent review: SHIP, all four tests manually drive real repository/EF state and none requires hosted dispatch; assertions unchanged. Full backend passed9141/5 skipped, focused webhook plus live fixture-isolation contract5/5. Two logs hash-preserved under .claude/local/milestone-20260909/preserved-2853-webhook/.tmp/issue-2853/; plain worktree removal succeeded after ignored inventory. Included in #2851 for qualification and delivery; no independent merge requested. |
The webhook resilience tests manually claim and transition real SQLite delivery rows, but their base fixture also started the webhook worker. A worker could claim an immediately due row before the test, producing the observed attempt-1 claim failure in #2851.
Use the existing HostedWorkerDisabledTestWebApplicationFactory for this class. All four tests retain their repository assertions; production workers and worker-dependent test classes are unchanged.
Refs #2853. One file, five additions and three deletions.
Validation:
No controlled runtime replay of the original scheduling race is claimed. The passing isolation contract verifies worker removal while retaining the web host. OUTSTANDING_TASKS.md is unchanged.