Skip to content

Isolate manual webhook resilience claims from hosted workers - #2854

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2853/webhook-fixture
Sep 9, 2026
Merged

Isolate manual webhook resilience claims from hosted workers#2854
Chris0Jeky merged 1 commit into
mainfrom
issue-2853/webhook-fixture

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

The webhook resilience tests manually claim and transition real SQLite delivery rows, but their base fixture also started the webhook worker. A worker could claim an immediately due row before the test, producing the observed attempt-1 claim failure in #2851.

Use the existing HostedWorkerDisabledTestWebApplicationFactory for this class. All four tests retain their repository assertions; production workers and worker-dependent test classes are unchanged.

Refs #2853. One file, five additions and three deletions.

Validation:

  • All four WebhookDeliveryResilienceTests plus the existing live-service fixture isolation contract: 5 passed, no skips.
  • Independent Terra review: SHIP; all four cases manually drive repository state, no worker dispatch scenario is removed. Reviewer ran no tests.
  • Full backend: dotnet test backend/Taskdeck.sln -c Release -m:1 passed 9141 tests with 5 declared skips, exit 0, at 5d7e3ad.

No controlled runtime replay of the original scheduling race is claimed. The passing isolation contract verifies worker removal while retaining the web host. OUTSTANDING_TASKS.md is unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T22:17:01.837460Z 5d7e3ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Terra independent review: SHIP, all four tests manually drive real repository/EF state and none requires hosted dispatch; assertions unchanged. Full backend passed9141/5 skipped, focused webhook plus live fixture-isolation contract5/5. Two logs hash-preserved under .claude/local/milestone-20260909/preserved-2853-webhook/.tmp/issue-2853/; plain worktree removal succeeded after ignored inventory. Included in #2851 for qualification and delivery; no independent merge requested.

@Chris0Jeky
Chris0Jeky merged commit 7ca2733 into main Sep 9, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2853/webhook-fixture branch September 9, 2026 22:43
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant