Skip to content

Release Chat continuation after failed post-send refresh - #2847

Merged
Chris0Jeky merged 2 commits into
mainfrom
issue-2004/chat-refresh-fail-fast
Sep 9, 2026
Merged

Release Chat continuation after failed post-send refresh#2847
Chris0Jeky merged 2 commits into
mainfrom
issue-2004/chat-refresh-fail-fast

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

A successful Chat send could keep "Sending..." and "Continue retained instruction" disabled while its reconciliation GET retried503 responses. This caused the SC-005b browser failure in required CI34394886556.

Post-send reconciliation now uses the existing skipRetry request option. The successful send's local messages and refresh-error feedback remain intact, and explicit session selection keeps its normal retry policy. No message is automatically resent or proposal applied.

Refs #2004. This addresses the measured refresh delay, not the whole Chat milestone issue.

Validation:

  • Baseline:1 failing regression,37 passing composable tests.
  • Focused API/composable tests:66 passed, including default request policy, failed-refresh busy cleanup and retained instruction.
  • Existing SC-005 browser scenarios:2 passed29.1s with Mock and synthetic data (ports5541/5841); no timeout increase.
  • Typecheck, build, scoped lint and diff hygiene passed.
  • Fullfrontend:397 files,6268 passed,3 skipped (145.45s).
  • Independent Terra review: SHIP, no causal HIGH/CRITICAL regression; reviewer did not run tests.
  • Required hosted CI remains owed.

The initial browser command stopped during setup because inherited retiredGemini settings were present; the child process environment was isolated to Mock with live providers disabled, then both tests passed. No repository provider configuration changed.

Coordination: #2846 owns separate context-selection changes in the same composable. Its diff was checked; this branch changes only the reconciliation request policy and needs fresh composition verification after either base lands. OUTSTANDING_TASKS.md unchanged; canonical docs remain with the other coordinator.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent fresh-context Terra review: SHIP, no causal HIGH/CRITICAL regression. Post-send reconciliation alone opts out of retries; explicit selection remains retrying, failed reconciliation preserves local sent/reply history and releases sendingMessage. Reviewer ran no tests.

Writer evidence:66focusedpass,fullfrontend397files6268pass3skip145.45s,typecheck/build/scopedlint/diffcheckpass; existing SC005browser2pass29.1s with syntheticMock. Sourcehead a257f45.

Fourteen evidence files (logs,testresults,syntheticDB) were copied and SHA256 verified under .claude/local/milestone-20260909/preserved-2004-failfast/. No owned listener remained on5541/5841. Generated snapshot normalized blob matchedHEAD; index metadata only refreshed. Worktree removed with plain git worktree remove; primary unrelated state preserved. Hosted qualification remains pending.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T20:09:46.602476Z a257f45 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The repair is now included in #2845 for combined qualification at3c7513dbfaf1cce8c1baf978be777f1041ddfc56 against main6dec7dba9. This source PR's refreshed head is a5a3233. Independent Terra composition review confirms every source file is byte-identical to the reviewed implementation, with no new HIGH/CRITICAL interaction. Combined required34399389111 is in progress; no source merge or delivery is claimed. Local test counts in this source body predate the latest base refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant