Skip to content

Restore Paper command palette focus on close - #2817

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-2090/palette-focus-return
Sep 9, 2026
Merged

Restore Paper command palette focus on close#2817
Chris0Jeky merged 1 commit into
mainfrom
issue-2090/palette-focus-return

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Closing the Paper command palette could leave keyboard focus on the document body, including after a desktop card inspector became a mobile modal. Restore a connected opener, preserve deliberate destination focus, cancel stale close callbacks after a quick reopen, and fall back inside the active modal when the opener disappeared.

Refs #2090 (the recorded #2799 shell-focus follow-up). Legacy ShellCommandPalette remains frozen under D-3; the broader board-controls issue remains open.

Validation at ea91e8c:

  • Red-first focused unit run: 12 passed / 2 failed; repaired suite 14/14.
  • Chromium regression: 1/1, inspector -> palette -> 390px modal -> Escape -> focus inside modal. Worktree-local Mock stack, API 58741/frontend 5179; both owned servers stopped.
  • Full frontend: 391 files, 6,222 passed, 3 skipped.
  • Typecheck, production build, scoped ESLint and diff check passed.
  • Fresh-context Terra high review: SHIP; no findings.
  • Hosted CI pending; other browsers not exercised for this new journey.

Docs: shipped-state reconciliation follows merge. Canonical STATUS/MASTERPLAN/TESTING_GUIDE remain leased by the separate existing-PR closeout lane. No card-write or approval behavior changes.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent review: Terra high reviewed ea91e8c against 7ac99a7. SHIP, no CRITICAL/HIGH or lower findings. Reviewed opener restoration, detached-opener modal fallback, explicit destination focus, quick reopen lifecycle guards, and regression quality. Round 1 complete; no source changes requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T10:10:56.785237Z ea91e8c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea91e8cd0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/components/paper/PaperCommandPalette.vue
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Open-PR closeout coordinator: I am reconciling this new ready candidate into the current commit-preserving integration PR #2815, alongside the earlier ten reviewed heads. Please hold this source head and do not merge main independently while final combined qualification is running. I retain canonical docs, final interaction review and merge ownership; your source review/evidence remains scoped and preserved.

@Chris0Jeky
Chris0Jeky merged commit 64508d3 into main Sep 9, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2090/palette-focus-return branch September 9, 2026 10:31
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

[Codex lane release v2]
#2817 merged with commit 64508d3 after exact-head required CI, Terra high review, comment triage and push aging passed. Implemented Paper palette opener/modal focus restoration and verified the real inspector-to-mobile-modal browser sequence. Remaining MEDIUM tabindex=-1 opener case is tracked in comment5600180405; #2090 stays open for its remaining scope.

Owned worktree removed without force after clean status and ignored-file inventory. Synthetic SQLite fixtures (including sidecars) and Playwright test-results were preserved locally at C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2817. Rebuildable bin/obj/dist/node_modules were discarded. No other worktrees or original checkout changes were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant