Restore Paper review recovery focus after unavailable links - #2816
Restore Paper review recovery focus after unavailable links#2816Chris0Jeky wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent review: Terra high reviewed head 98aa1c9 against base 7ac99a7. SHIP; no CRITICAL/HIGH or lower findings. Reviewed hash-change notice invalidation, async unavailable focus, one-action return, and successful deep-link selection. Review was read-only; local verification is recorded in the PR body. Round 1 complete. |
|
CI triage: the first Smart CI shadow receipt failed before job evidence with planner-error: pull-request planning requires merge SHA and tree SHA from the same fetched merge ref. This matches the existing #2562/#2327 merge-ref report. The merge ref is now present; one complete Smart CI rerun was requested so the planner runs again. Required CI run 34337935227 is active. No CI code or gates changed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98aa1c9ecb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Open-PR closeout coordinator: I am reconciling this new ready candidate into the current commit-preserving integration PR #2815, alongside the earlier ten reviewed heads. Please hold this source head and do not merge main independently while final combined qualification is running. I retain canonical docs, final interaction review and merge ownership; your source review/evidence remains scoped and preserved. |
|
Base integration checkpoint: merged main at 64508d3, preserving commits. New head ac9df55. The scoped PR patch-id is identical to the independently reviewed patch; no new feature logic was added beyond the already reviewed palette base. 232 review/palette tests and typecheck passed on the combined head. Existing full-suite evidence remains as recorded; fresh required hosted CI is pending. No merge claim until that gate passes. |
|
Delivered through merged integration PR #2815 at22029c760653519622de2e9bcdd86bb668a50d41. Read-only git merge-tree against this branch produces exactly the current main tree3a1a2b7bdbc3e6f844a411abd52a1c5f694bd458, so merging this PR would introduce no file changes. Closing the superseded PR without another merge. Original feature commits, local proofs and review comments remain available; parent issue residuals and human acceptance are not closed. |
|
Current-head checks are green. The source change is already delivered in #2815; this remaining base-merge head produces exactly main tree3a1a2b7bdbc3e6f844a411abd52a1c5f694bd458 when merged. Finalizing the PR preserves its later ancestry without changing any qualified source, test or configuration blob. |
|
[Codex lane release v2] Return-focus repair is delivered through #2815 at22029c760653519622de2e9bcdd86bb668a50d41. #2816 was closed as superseded after identical merge-tree proof against main. The MEDIUM asynchronous focus-steal residual remains tracked here. Owned worktree removed with plain git worktree remove after clean/ignored inventory; only rebuildable frontend dist/node_modules were discarded. Original checkout and other worktrees preserved. |
1 participant
Missing or malformed proposal links reached from the Paper settled-elsewhere notice could lose keyboard focus and reveal the old notice again after Back to Review. Clear that stale identity when the link changes and move focus to the unavailable recovery control, then return to the queue or empty state in one action.
Refs #2215. This resolves the two recorded PR #2785 return-path residuals; it does not close the wider issue. Legacy remains frozen.
Validation at 98aa1c9:
Docs: no shipped-state claim before merge. STATUS/MASTERPLAN/TESTING_GUIDE are currently leased by the separate open-PR closeout lane; delivery reconciliation is deferred until that lane lands. No approval or execution semantics change.