test: prove SSE first-delta delivery at the API boundary - #2812
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Final scoped Luna verification completed at d0ba6c9 for the corrections after the original Terra-reviewed c80a064 head. Two focused tests passed; typed LlmTokenEvent parsing matches the controller serialization, and the gated handshake, frame order and payload assertions remain meaningful. No causal C/H correctness, false-positive or hang blocker. Optional TokensUsed/Provider/Model fields are not individually asserted: informational coverage scope, not a defect or new fix request. Author full backend proof remains 8,975 passed / 5 existing skips at this final head. Required hosted CI is still separate. |
|
Session wrap-up: all source is pushed at d0ba6c9. Focused and full test logs/exit receipts plus generated OpenAPI evidence were copied outside the disposable checkout to C:\Users\Public\codex-shell-home\taskdeck-wave-20260908\issue-2241; test-file SHA-256 copies were verified before cleanup. The clean checkout will be removed normally by the coordinator; generated bin/obj caches are disposable. Final fix verification is recorded above. This ready PR remains open for required CI and next-session reconciliation; no monitor or test process remains owned by this session. |
…o codex/2241-base-verification
|
Current-base refresh preserves the reviewed SSE tests without source edits. New head b46496f includes main 1777e3c; the added base delta since 0a02085 is the reviewed documentation record #2813. Targeted ChatSseApiTests pass 2/2 on the merged source. Original full-backend proof and completed review/fix record remain applicable to unchanged code; fresh hosted CI is required at this new head. Base-only interaction review is being reconciled; no additional feature/fix round. |
|
Base-only Terra reconciliation completed: no current-base blocker. The only added base delta is the reviewed documentation record #2813; original SSE review and final scoped fix verification remain applicable. Two API tests pass on this new head. No new finding or additional review round. |
|
Final current-base Terra reconciliation is clear. The refresh is a two-parent merge of the prior reviewed head and main f935ebc; its only added paths are the five representation-contract files, byte-identical to main, with no conflict-resolution edits. The added contract remains unregistered/unmapped with no runtime writer and no direct interaction with this reviewed seam was found. Original source/fix reviews remain applicable; fresh hosted CI at the refreshed head is the remaining gate. Closeout: PR #2814 and C:/Taskdeck-wave/evidence/HANDOFF.md. |
|
Fresh Terra base-interaction review completed against main 7ac99a7: no CRITICAL/HIGH blocker. Each current head was materialized and its merge tree reconciled cleanly. Original source/fix reviews remain applicable. For the control seams, control-trust tests passed 4/4 (#2792), nightly tests passed 35/35 with docs checks (#2791). Fresh current-head hosted CI remains required; this comment does not waive the maintainer-review gate on control paths. |
1 participant
Add controller-level tests that prove the first SSE delta is readable before the provider completes. A gated provider and ResponseHeadersRead make the assertion deterministic; the tests also check event order, JSON payloads, blank-line framing, a single text/event-stream content type and compatibility with an immediately available response.
This is the AC3 API-test slice of #2241. It does not change production chat code or claim a real proxy/socket buffering test, a live provider smoke, or the whole issue's acceptance.
Validation at d0ba6c9: 2 focused tests passed; full
dotnet test backend/Taskdeck.sln -c Release -m:1exited 0 with 8,975 passed, 5 existing skips, 0 failures. Initial proving exposed a missing System.Net.Http.Json import and a test payload-casing assumption; the two test-only corrections are committed before publication. Final project counts: Domain 1605, Application 4206, API 2857 plus 4 skips, CLI 243, Architecture 28 plus 1 skip, Integration 36.The original deterministic handshake and wire-framing implementation received independent Terra review without a C/H blocker. A scoped Luna check covers the subsequent test-only import/deserialization corrections. Hosted exact-head CI remains required before merge. Logs and exit receipts will be preserved outside the disposable worktree; no private data or provider credentials were used.
Refs #2241