Define canonical processing policy snapshots - #2811
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra review completed against ad02598 and actual base db102dc. No confirmed CRITICAL/HIGH blockers. The reviewer independently recomputed the golden digest and checked canonical field ordering, explicit nulls, UTC date and decimal formatting, normalized allowlist semantics, immutable snapshots and input validation. The contract accurately defers persistence and runtime enforcement to later CF-03/CF-10 slices. The reviewer ran no .NET tests. Separately, the author passed 12 focused tests and the coordinator captured exit 0 from the full backend process at this unchanged head. Final full-suite counts were not captured. Hosted required CI remains the final ordinary merge gate; #2257 stays open for its larger scope. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad02598a03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Session wrap-up: source at ad02598 is pushed and this PR remains open for its outstanding gate. Required local evidence is preserved under C:\Users\Public\codex-shell-home\taskdeck-wave-20260908\issue-2257-full-backend-process-receipt.json. The coordinator is removing the disposable issue worktree normally after verifying a clean source tree and upstream equality; generated bin/obj, dist and dependency caches are disposable. No active writer remains in this lane. |
… codex/2811-base-verification
|
Current-base verification completed: 92d658d includes main 1777e3c and preserves the original reviewed policy contract without source edits. Luna xhigh passed 12 focused policy tests and docs links/governance; Terra high reconciled base changes and found no current-base blocker or changed contract paths. Existing review and the two tracked P2 dispositions on #2257 remain intact. Fresh exact-head CI is pending. |
|
Verification checkout removed normally after confirming clean tracked state and both remote refs at the verified head. Ignored files were only disposable backend bin/obj outputs. Review diff and cleanup inventory are preserved at C:/Taskdeck-wave/evidence/2811; source remains pushed on this PR and the verification branch. No active writer remains. |
|
Final current-base Terra reconciliation is clear. The refresh is a two-parent merge of the prior reviewed head and main f935ebc; its only added paths are the five representation-contract files, byte-identical to main, with no conflict-resolution edits. The added contract remains unregistered/unmapped with no runtime writer and no direct interaction with this reviewed seam was found. Original source/fix reviews remain applicable; fresh hosted CI at the refreshed head is the remaining gate. Closeout: PR #2814 and C:/Taskdeck-wave/evidence/HANDOFF.md. |
|
Fresh Terra base-interaction review completed against main 7ac99a7: no CRITICAL/HIGH blocker. Each current head was materialized and its merge tree reconciled cleanly. Original source/fix reviews remain applicable. For the control seams, control-trust tests passed 4/4 (#2792), nightly tests passed 35/35 with docs checks (#2791). Fresh current-head hosted CI remains required; this comment does not waive the maintainer-review gate on control paths. |
1 participant
Freeze the CF03-1 ProcessingPolicySnapshot contract and its canonical SHA-256 digest for future processing jobs. The immutable snapshot records egress class, normalized processor allowlist, feature flags, UTC deadline and a currency-qualified decimal cost ceiling. It adds no queue, runner, persistence, migration or runtime writer.
Canonical compact UTF-8 JSON pins field order, explicit nulls, enum/date/decimal spelling and lowercase digest output. Validation rejects undefined egress values, invalid processor identifiers, non-UTC deadlines, negative costs and noncanonical currency text; empty allowlists fail closed. The dedicated contract document defines the byte format and future persistence obligations.
Validation at ad02598: 12 focused policy tests passed, including golden bytes/digest and invalid-input cases. Full
dotnet test backend/Taskdeck.sln -c Release -m:1exited 0. Its original shell session ID was lost; the coordinator retained the running process handle and recorded its actual exit code at 01:34:05Z. Final per-project totals were not captured and are not claimed. Doc links (664 files) and eight Context Fabric contract drafts passed. Independent Terra review against base db102dc found no CRITICAL/HIGH blockers and independently recomputed the golden digest.CF03-2 must persist the digest beside a job; CF-10 must create snapshots from profiles. Null constraints do not authorize an unbounded runtime path: a future runner must enforce its own limits. The parent remains open. Canonical STATUS/MASTERPLAN updates are coordinator-owned; OUTSTANDING_TASKS.md is unchanged by this slice.
Refs #2257