test: isolate default product version reads from HTTP - #2810
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra source review completed against head 21e1ef2 and base db102dc. No CRITICAL/HIGH blocker. The shared fixture replaces only versionApi.getProductVersion. The dedicated transport contract explicitly un-mocks the real module and retains HTTP/base-url/payload/error assertions; local composable and shell stubs remain available. The new regression proves the default version path does not call HTTP. The reviewer ran no heavy tests. Author execution separately completed typecheck/build and the full unit suite at the same unchanged head: 381 files, 6,153 passed, 3 skipped, exit 0. The 55 ECONNREFUSED strings in the passing full log are console output, not failed assertions; their request origins remain unattributed, and no global network-silence claim is made. |
|
Session wrap-up: source at 21e1ef2 is pushed and this PR remains open for its outstanding gate. Required local evidence is preserved under C:\Users\Public\codex-shell-home\taskdeck-wave-20260908\issue-2775. The coordinator is removing the disposable issue worktree normally after verifying a clean source tree and upstream equality; generated bin/obj, dist and dependency caches are disposable. No active writer remains in this lane. |
…' into codex/2775-unit-health-refresh
|
Current-base refresh f05e6a8 preserves the original version-health isolation change and current main 1777e3c. Luna xhigh passed four focused files / 94 tests including the default fixture, real transport and AppShell seams; typecheck and diff checks pass. No conflicts or additional source edits. Original full-suite proof and independent review remain recorded; Terra is checking the base interaction and fresh hosted CI is required. |
|
Terra base-interaction reconciliation is clear. The current AppShell delta gates keyboard shortcuts on feature flags; the global version fixture only isolates transitive version reads, and the transport spec still un-mocks the real API. Passing integrated AppShell/default-fixture/transport tests exercise that seam. No new blocker or extra review round. |
|
Verification checkout removed normally after clean source/upstream verification. Its only ignored directory was the disposable dependency install. Review diff and cleanup inventory remain at C:/Taskdeck-wave/evidence/2810; original and verification source refs are pushed. |
|
Final current-base Terra reconciliation is clear. The refresh is a two-parent merge of the prior reviewed head and main f935ebc; its only added paths are the five representation-contract files, byte-identical to main, with no conflict-resolution edits. The added contract remains unregistered/unmapped with no runtime writer and no direct interaction with this reviewed seam was found. Original source/fix reviews remain applicable; fresh hosted CI at the refreshed head is the remaining gate. Closeout: PR #2814 and C:/Taskdeck-wave/evidence/HANDOFF.md. |
|
Fresh Terra base-interaction review completed against main 7ac99a7: no CRITICAL/HIGH blocker. Each current head was materialized and its merge tree reconciled cleanly. Original source/fix reviews remain applicable. For the control seams, control-trust tests passed 4/4 (#2792), nightly tests passed 35/35 with docs checks (#2791). Fresh current-head hosted CI remains required; this comment does not waive the maintainer-review gate on control paths. |
1 participant
Unit tests that read the product version now use an offline default fixture instead of the live version-health request. The dedicated versionApi transport spec explicitly un-mocks the module, preserving its request, payload and error contract assertions. A new regression proves the default composable path makes zero Axios calls.
Validation at 21e1ef2: typecheck, production build, scoped lint and focused isolation tests passed.
npx vitest --run --maxWorkers=2completed without a backend: 381 files passed, 6,153 tests passed, 3 skipped, exit 0 in 151.80s. No worker-startup timeout occurred in that completed run.The passing full run still emits 55 ECONNREFUSED strings from tests; its error output omits request URLs, so those messages are not attributed to /health/live and a globally network-silent suite is not claimed. The directly tested version path is isolated. An earlier full attempt was interrupted after mistaking console errors for test failures; the completed run establishes that those messages do not prevent completion. Logs/exit receipts are in the worktree's ignored frontend/taskdeck-web/test-results/issue-2775 directory and will be preserved outside the worktree before cleanup.
Independent Terra source review at this frozen head found no CRITICAL/HIGH blockers. Hosted exact-head CI remains required. STATUS/MASTERPLAN are updated by the coordinator; OUTSTANDING_TASKS.md is unchanged by this test-only slice.
Closes #2775