Conversation
Pins both directions: a later request that selects totalCount must see ConnectionFlags.TotalCount, and a later request that omits it must not.
GetConnectionFlags derived the flags with the include flags of whichever request ran first and cached them on the selection, which lives as long as the compiled operation. A connection whose selection set is gated by @skip/@include therefore kept answering with the first request's flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
GetConnectionFlagscaches on the selection, which lives as long as the compiledoperation. A value derived from the include flags of whichever request ran first. A connection
gated by
@skip/@includethen keeps those flags, so after one request withouttotalCountevery later request asking for it fails with
HC0018.Fix: recompute the flags per request when the connection's selection set is conditional;
the unconditional case keeps the cache.
Closes #10396