Skip to content

fix(parquet): pass ReadHints into VECTOR ParquetFileBatchReader tests - #5

Draft
ChaomingZhangCN wants to merge 1 commit into
mainfrom
cursor/fix-parquet-vector-create-hints-00b9
Draft

fix(parquet): pass ReadHints into VECTOR ParquetFileBatchReader tests#5
ChaomingZhangCN wants to merge 1 commit into
mainfrom
cursor/fix-parquet-vector-create-hints-00b9

Conversation

@ChaomingZhangCN

@ChaomingZhangCN ChaomingZhangCN commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Purpose

Restore main CI after apache/paimon-cpp#198 merged on top of apache/paimon-cpp#209.

ParquetFileBatchReader::Create now requires a ReadHints argument. #198 added parquet_vector_io_test.cpp with the previous 6-argument call, so the merge compiled as:

parquet_vector_io_test.cpp:158: error: too few arguments to function call, expected 7, have 6
parquet_vector_io_test.cpp:179: error: too few arguments to function call, expected 7, have 6

That failed Build and Test on apache main after the merge (clang-debug-x86_64, gcc-debug-x86_64, gcc-debug-aarch64, sanitizers, and other jobs). Example: https://github.com/apache/paimon-cpp/actions/runs/32324365666

Pass /*hints=*/std::nullopt at both VECTOR test call sites, matching the other Parquet reader tests.

This branch is based on current main (afc8471). Open the same change against apache with:

apache/paimon-cpp@main...ChaomingZhangCN:paimon-cpp:cursor/fix-parquet-vector-create-hints-00b9

Tests

  • ParquetVectorIoTest in src/paimon/format/parquet/parquet_vector_io_test.cpp

Local validation (Debug, g++ 13, existing build/):

cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DPAIMON_BUILD_TESTS=ON
cmake --build build --target paimon-parquet-format-test paimon-common-test paimon-core-test paimon-write-and-read-inte-test -j 4
./build/debug/paimon-parquet-format-test --gtest_filter='ParquetVectorIoTest.*:ParquetVectorConverterTest.*'   # 13 passed
./build/debug/paimon-common-test --gtest_filter='VectorUtilsTest.*:ArrowUtilsTest.TestCheckNullableMatchRejects*'   # 5 passed
./build/debug/paimon-core-test --gtest_filter='VectorFileBatchReaderTest.*:SchemaValidationTest.TestVectorType:ArrowSchemaValidatorTest.TestVectorElementType'   # 8 passed
./build/debug/paimon-write-and-read-inte-test --gtest_filter='*Vector*'   # 9 passed
./build/debug/paimon-parquet-format-test   # 201 passed

API and Format

API: No.

Schema protocol: No.

Storage format: No.

Documentation

No.

Generative AI tooling

Generated-by: Cursor Cloud Agent (Cursor Grok 4.6)

Open in Web Open in Cursor 

apache#198 landed after apache#209 made ReadHints a required Create() argument.
The new VECTOR tests still used the old 6-argument call, so main CI
failed to compile parquet_vector_io_test.cpp.

Co-authored-by: 小明同学 <ChaomingZhangCN@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants