fix(parquet): pass ReadHints into VECTOR ParquetFileBatchReader tests - #5
Draft
ChaomingZhangCN wants to merge 1 commit into
Draft
fix(parquet): pass ReadHints into VECTOR ParquetFileBatchReader tests#5ChaomingZhangCN wants to merge 1 commit into
ChaomingZhangCN wants to merge 1 commit into
Conversation
apache#198 landed after apache#209 made ReadHints a required Create() argument. The new VECTOR tests still used the old 6-argument call, so main CI failed to compile parquet_vector_io_test.cpp. Co-authored-by: 小明同学 <ChaomingZhangCN@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restore
mainCI after apache/paimon-cpp#198 merged on top of apache/paimon-cpp#209.ParquetFileBatchReader::Createnow requires aReadHintsargument.#198addedparquet_vector_io_test.cppwith the previous 6-argument call, so the merge compiled as:That failed Build and Test on apache
mainafter the merge (clang-debug-x86_64,gcc-debug-x86_64,gcc-debug-aarch64, sanitizers, and other jobs). Example: https://github.com/apache/paimon-cpp/actions/runs/32324365666Pass
/*hints=*/std::nulloptat both VECTOR test call sites, matching the other Parquet reader tests.This branch is based on current
main(afc8471). Open the same change against apache with:apache/paimon-cpp@main...ChaomingZhangCN:paimon-cpp:cursor/fix-parquet-vector-create-hints-00b9
Tests
ParquetVectorIoTestinsrc/paimon/format/parquet/parquet_vector_io_test.cppLocal validation (Debug, g++ 13, existing
build/):API and Format
API: No.
Schema protocol: No.
Storage format: No.
Documentation
No.
Generative AI tooling
Generated-by: Cursor Cloud Agent (Cursor Grok 4.6)