fix: add processing lease to idempotency store - #453
Open
nasalehj wants to merge 1 commit into
Open
Conversation
Processing records previously held a key forever: if the process died between acquire and complete, every retry returned 409 until a manual cleanup. Add a lease_expires_at column refreshed by a middleware heartbeat while the handler runs, atomically re-acquire abandoned leases, and persist the result before delivering the response so a replay never observes processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #429. The idempotency store treated a
processingrecord as permanent untilcomplete()ran — andcomplete()was fire-and-forget:processingforever and every retry with the sameIdempotency-Keyreturned 409 indefinitely.complete()wasn't awaited, a fast retry could observeprocessingafter the first response had already been delivered, violating the "same key ⇒ same result" guarantee.Changes
tryAcquirestampslease_expires_atonprocessingrecords, and the middleware refreshes it via aheartbeat()interval while the handler runs, so a slow request is never mistaken for an abandoned one.processingrecord whose lease has expired is atomically claimed (row-level lock) by the next request with the same key — a crashed request's key is recovered within a bounded window, and an abandoned lease can never run the handler twice concurrently.complete()has committed, so a retry arriving after the first response replays the cached result (200) instead of returning 409.Closes #429