fix: refresh credentials before replaying evidence uploads - #437
Open
tolulopedd26 wants to merge 1 commit into
Open
fix: refresh credentials before replaying evidence uploads#437tolulopedd26 wants to merge 1 commit into
tolulopedd26 wants to merge 1 commit into
Conversation
The offline sync queue captured evidence upload URLs and headers verbatim, so a signed URL that expired while the device was offline would strand the upload after maxRetries. This change adds a per-action credential-refresh hook invoked when a retry fails with a credential-expiry error (401/403). The refreshed URL and headers are persisted back into the queued action so the next retry cycle uses fresh credentials. Closes ChainForgee#435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The offline sync queue captured evidence upload URLs and headers verbatim, so a signed URL that expired while the device was offline would strand the upload after maxRetries.
This change adds a per-action credential-refresh hook invoked when a retry fails with a credential-expiry error (401/403). The refreshed URL and headers are persisted back into the queued action so the next retry cycle uses fresh credentials.
Closes #435
Testing
Checklist