Add regional clothing preset configurator - #99
Open
izabellamilto wants to merge 1 commit into
Open
Conversation
Co-authored-by: Izabella Milto <259171528+izabellamilto@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
izabellamilto
marked this pull request as ready for review
July 28, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution
This contribution was initiated and designed by Izabella Milto (@izabellamilto). The implementation was developed collaboratively with Michał Przybylski (@MichaelZP).
Summary
• add a Use preset ensemble modal next to the custom ensemble workflow
• provide all 52 measured female and male ensembles from Havenith et al. (2013), ASHRAE RP-1504
• populate 11 regional insulation values and the whole-body Icl value from the selected ensemble
• recalculate whole-body Icl when regional values are edited manually
• show body-zone-specific garment choices and a readable description of the measured clothing reference
• keep the preset data in a dedicated module so values and descriptions can be maintained easily
Why
Regional insulation numbers alone do not explain what the manikin is wearing. The measured presets provide a recognizable starting point, while zone-specific refinement lets users describe the actual clothing and adjust individual values precisely.
The existing regional editor also left the whole-body Icl result stale after a manual edit. The regional inputs are now connected to the area-weighted recalculation.
Data interpretation
The report supplies regional measurements for complete ensembles, not isolated clo values for every individual garment. Garment selections therefore provide zone-relevant clothing context; they do not claim standalone garment insulation measurements.
Validation
• 6 automated tests passed
• JavaScript syntax checks passed
• Git diff validation passed
• the modal and regional editing workflow were tested locally