Design Agents for Owner Community - #309
Open
OliviaKnestaut wants to merge 3 commits into
Open
Conversation
Contributor
Reviewer's GuideIntroduces three GitHub agent definition files to orchestrate design auditing and UI implementation for the OwnerCommunity app, and slightly updates workspace dependency overrides for brace-expansion and fast-uri. Sequence diagram for the design audit and implementation workflowsequenceDiagram
actor User
participant orchestrator_design
participant design_audit
participant implementer_ui
User->>orchestrator_design: provide_request
%% STEP 1: initial design-audit
orchestrator_design->>design_audit: agent(analyze_and_plan)
design_audit-->>orchestrator_design: audit_plan_and_checklist
%% STEP 2: initial implementer
orchestrator_design->>implementer_ui: agent(initial_implementation)
implementer_ui-->>orchestrator_design: implementation_result
%% STEP 3: review design-audit
orchestrator_design->>design_audit: agent(review_implementation)
design_audit-->>orchestrator_design: review_verdict
alt issues_found
%% STEP 4: feedback implementer
orchestrator_design->>implementer_ui: agent(fix_review_findings)
implementer_ui-->>orchestrator_design: feedback_fix_result
else pass
orchestrator_design-->>User: report_pass_status
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 5 issues, and left some high level feedback:
Fixed security issues:
-
fast-uri (link)
-
The orchestrator agent lists
agents: ['design-audit', 'implementer']but the implemented UI agent is namedimplementer-ui, so update the agents array or the agent name to keep orchestration working. -
The setup step uses
which design.md || pnpm add -g @google/design.md, butDESIGN.mdis a project file rather than an executable, so replace thewhichcheck with a filesystem check under the repo root to avoid unnecessary global installs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The orchestrator agent lists `agents: ['design-audit', 'implementer']` but the implemented UI agent is named `implementer-ui`, so update the agents array or the agent name to keep orchestration working.
- The setup step uses `which design.md || pnpm add -g @google/design.md`, but `DESIGN.md` is a project file rather than an executable, so replace the `which` check with a filesystem check under the repo root to avoid unnecessary global installs.
## Individual Comments
### Comment 1
<location path=".github/agents/design-audit.md" line_range="26-29" />
<code_context>
+fresh headed session. If running independently and an existing session's headed
+state cannot be confirmed, close only that named session once and reopen it with
+`agent-browser --session ownercommunity-desktop open --headed https://ownercommunity.localhost/`;
+keep `--headed` before the URL. Do not rely on `--headed` to convert an existing
+After a fresh headed session is available, leave it open and reuse it.
+
+Use `agent-browser --session ownercommunity-desktop` for every browser command so the
</code_context>
<issue_to_address>
**issue (typo):** The sentence about `--headed` is truncated and missing a noun (e.g., "session"), making it grammatically incomplete.
This line is immediately followed by `After a fresh headed session is available...`, so it reads as cut off. Please complete it, e.g. `Do not rely on --headed to convert an existing headless session`, to keep the instructions clear and unambiguous.
```suggestion
state cannot be confirmed, close only that named session once and reopen it with
`agent-browser --session ownercommunity-desktop open --headed https://ownercommunity.localhost/`;
keep `--headed` before the URL. Do not rely on `--headed` to convert an existing headless session;
create a new headed session instead.
After a fresh headed session is available, leave it open and reuse it.
```
</issue_to_address>
### Comment 2
<location path=".github/agents/orchestrator-design.md" line_range="8" />
<code_context>
+ You control workflow by delegating tasks to specialized subagents.
+model: kimi-k2.7-code
+tools: ['agent', 'execute']
+agents: ['design-audit', 'implementer']
+---
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Front matter references an `implementer` agent, but the defined agent is named `implementer-ui`, which may break delegation.
This config lists an `implementer` agent, but the only agent you’ve added is `implementer-ui.agent.md` with `name: implementer-ui`. Unless another `implementer` agent exists, this mismatch will prevent the orchestrator from calling the UI agent. Please either rename the agent to `implementer` or update the config (and inline references) to `implementer-ui` for consistency.
</issue_to_address>
### Comment 3
<location path=".github/agents/design-audit.md" line_range="136" />
<code_context>
+
+Before auditing any code, read the relevant instruction files:
+
+- `DESIGN.md` — general agent instructions for designing using intealth branding
+
+### UI Changes
</code_context>
<issue_to_address>
**suggestion (typo):** Possible typo in the brand name "intealth"; consider capitalizing or confirming the intended spelling.
If "intealth" is a proper brand name, update it to "Intealth"; if the lowercase form is intentional, then no change is needed.
```suggestion
- `DESIGN.md` — general agent instructions for designing using Intealth branding
```
</issue_to_address>
### Comment 4
<location path=".github/agents/implementer-ui.agent.md" line_range="158" />
<code_context>
+
+Before auditing any code, read the relevant instruction files:
+
+- `DESIGN.md` — general agent instructions for designing using intealth branding
+
+### UI Changes
</code_context>
<issue_to_address>
**suggestion (typo):** Same potential "intealth" brand-name typo appears here; align with the intended capitalization.
This line mirrors the one in `design-audit.md` and also uses `intealth branding`. If `Intealth` is a proper name, update the capitalization/spelling here to keep branding consistent across documents.
Suggested implementation:
```
- `DESIGN.md` — general agent instructions for designing using Intealth branding
```
1. Search the repository (especially other agent and instruction markdown files, e.g., `design-audit.md`) for "intealth" and standardize to "Intealth" wherever it refers to the brand name.
2. If there is a documented branding guideline (e.g., in `DESIGN.md`), confirm the canonical capitalization ("Intealth") and keep all future additions consistent with it.
</issue_to_address>
### Comment 5
<location path=".github/agents/design-audit.md" line_range="82" />
<code_context>
+
+## Mission
+
+You audit and critically review the implemented UI against the OpenPencil designs, DESIGN.md and product quality bars. Assume defects exist until proven otherwise.
+
+Before first use, check if Open Pencil, agent-browser, and DESIGN.md are installed. If not, install them automatically:
</code_context>
<issue_to_address>
**nitpick (typo):** Inconsistent naming of "OpenPencil" vs "Open Pencil" across documents; consider standardizing.
This section mixes `OpenPencil designs` and `Open Pencil`. Please choose one naming convention and use it consistently throughout the docs so it’s clear they refer to the same tool.
Suggested implementation:
```
You audit and critically review the implemented UI against the OpenPencil designs, DESIGN.md and product quality bars. Assume defects exist until proven otherwise.
Before first use, check if OpenPencil, agent-browser, and DESIGN.md are installed. If not, install them automatically:
OpenPencil:
```
Search the rest of `.github/agents/design-audit.md` (and related docs if they reference this agent) for any remaining occurrences of `Open Pencil` and standardize them to `OpenPencil` to keep the naming convention consistent throughout the documentation.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Set up an agent-based workflow for OwnerCommunity design work, including audit, implementation, and orchestration agents, while updating a couple of dependency overrides in the pnpm workspace.
New Features:
Enhancements:
Build:
Documentation: