Use cache-less resource loading to resolve C# GC_handle crash issues. - #206
Open
Seb105 wants to merge 2 commits into
Open
Use cache-less resource loading to resolve C# GC_handle crash issues.#206Seb105 wants to merge 2 commits into
Seb105 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
This PR replaces all instances
GD.Load(...)withResourceLoader.Load(..., cacheMode: IgnoreDeep)This appears to resolve the CTD issue however it will always load a resource from disk, never from Godot's cache (as it is the cache causing this crash). Resource loading may be slower depending on how you use ResouceTree as a result.
In the issue I linked in #205 there are some examples of a resource cache implementation, which I haven't done in this PR.
Testing:
dotnet testis passing, and it compiles & works for my actual project whilst resolving the issue. but I couldn't get the test project to work even before making my changes, so I can't confirm full coverage.