Repository navigation
ci(instant): record Linux Instant with a virtual camera - #3425
Merged
Merged
Conversation
# Conflicts: # apps/desktop-gpui/src/upload/real_app_tests.rs
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@greptileai review |
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 28, 2026 19:24
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux, Instant draws the camera into the screen video, so a camera that stalls or sends a bad frame stops the recording. No CI case recorded Instant with a camera: Blacksmith's kernel cannot load v4l2loopback.
real_app_instant_recording_with_camera_uploads_and_verifies, gated onCAP_GPUI_REAL_APP_CAMERA=1. It selects the first camera and records a full-screen window; X11 waits for the Stop shortcut before a camera window recording starts, so the case presses it to start and stop. It checks the upload verifies, the mock server confirms it, nothing is deleted and nothing panics.ubuntu-24.04job loads v4l2loopback (withlinux-modules-extrafor videodev), feeds a 720p YUYV test pattern, runs the case, then joins the recorded segments and checks at least 95% of frames carry the pattern's colour. The recorded window is grey, so a frame without colour is a frame without the camera.crates/camera,crates/camera-ffmpegandcrates/recording/src/instant_recording/.Test plan


Confidence Score: 5/5
The PR appears safe to merge; the previous filter issue is fixed.Summary
Adds a Linux CI check that records Instant with a virtual camera and checks that its picture reaches the saved video.
Reviews (3) · Last reviewed commit: "ci(instant): run the camera case for cam..." · Reviewed by Greptile