Repository navigation
Conversation
Dispatch the editor preview's RGBA row unpad through AVX2, or SSSE3 when AVX2 is absent. The same function tightens portable camera-blur readback when that texture is RGBA.
Contributor
|
@kyzer1023 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+514
to
+516
| if is_x86_feature_detected!("ssse3") { | ||
| let ssse3 = unsafe { unpad_rgba_to_bgra_ssse3(&data, width, stride, rows, width * 4) }; | ||
| assert_eq!(ssse3, scalar); |
Contributor
There was a problem hiding this comment.
On an AVX2 machine, the odd-width and padding test always selects AVX2. The only direct SSSE3 test uses width 1248, which is divisible by four, so it never checks where SSSE3 stops and the scalar tail starts. This leaves fallback boundary mistakes undetected on those machines.
Run the existing width-and-stride cases directly through each supported helper, keeping the feature checks.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop-gpui/kernels/src/frame.rs
Line: 514-516
Comment:
**SSSE3 edge cases go unchecked**
On an AVX2 machine, the odd-width and padding test always selects AVX2. The only direct SSSE3 test uses width 1248, which is divisible by four, so it never checks where SSSE3 stops and the scalar tail starts. This leaves fallback boundary mistakes undetected on those machines.
Run the existing width-and-stride cases directly through each supported helper, keeping the feature checks.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Run the existing odd-width and padded-stride cases through the scalar, SSSE3, and AVX2 helpers, gated by runtime feature detection. The dispatcher picks AVX2 whenever it is available, so those cases never reached the SSSE3 tail before.
Contributor
Author
|
@greptileai review |
1 similar comment
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unpad_rgba_to_bgra(used byframe_imagefor every RGBA editor preview frame, and portable camera-blur readback when the texture is RGBA) now uses AVX2vpshufb(8 px) when available, SSSE3 (4 px) otherwise, and the prior scalar loop as fallback. Channel swap + tight pack of already-RGBA pixels — does not replace YUYV/NV12/BGRZ kernels (#3294 path still coexists).Benchmarks
rustc 1.95.0,
opt-level=3, thin LTO,codegen-units=1,RUSTFLAGS=-C target-cpu=x86-64. Intel Xeon family 6 model 207 (AVX2+SSSE3). Warmup 10, 30 measured, interleaved, median. Before = scalar pointer loop in the same binary.Tests
Release
assert_eqmatched on all three sizes. Unit tests: AVX2 and SSSE3 match scalar on full 1248×702 (odd widths + padding).Notes
kyzer/desktop-gpui-avx2-rgba-bgra-unpad-5e89(Kyzer sole author).
The PR appears safe to merge; the previous test coverage gap is fixed.Summary
Adds AVX2 and SSSE3 paths for swapping RGBA to BGRA while removing row padding, with a scalar fallback.
Reviews (3) · Last reviewed commit: "test(desktop-gpui): cover ssse3 unpad ta..." · Reviewed by Greptile