Repository navigation
fix(render-farm): transcode odd-sized recordings on CPU - #2955
Merged
richiemcilroy merged 1 commit intoOct 23, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU source transcodes reject browser recordings with an odd width or height. Pad only the CPU path to the next even dimensions, adding at most one row or column so libx264 can encode H.264 4:2:0.
Closes #2954.
All fixed files decode and pass production MP4 indexing and remux checks. The default NVENC arguments are unchanged; all four NVENC control files match byte for byte on the tested RTX 5060.
Validation: all 163 render-farm tests pass, including three real FFmpeg regressions that fail on main. Scoped Biome and strict TypeScript checks pass. Integration tests skip explicitly when FFmpeg or ffprobe is absent. Tested with FFmpeg n9.0.2 on Linux; no live worker fleet or older FFmpeg version was exercised.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Adds even-dimension padding to CPU source transcodes so odd-sized recordings can be encoded with
libx264.Reviews (1) · Last reviewed commit: "fix(render-farm): transcode odd-sized re..." · Reviewed by Greptile