Repository navigation
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One temporary download-server error can leave
cap-setupfailing on every retry. It caches the HTTP error body as a native dependency archive and never downloads it again.Check the HTTP status before reading bytes in the five unguarded download paths. Add a regression that executes the complete setup script with real HTTP and tar, and run it in Linux CI after the required desktop dependencies are installed.
Closes #2952.
Validation: the new regression fails on main and passes with the fix. All eight setup/Linux bundle configuration tests pass, along with scoped Biome, Node syntax checks and CI YAML parsing. The fixture verifies staged library contents and generated configurations using synthetic library archives. Native macOS/Windows setup and application builds were not run locally.
This prevents new HTTP-error cache entries; it does not repair an already-poisoned archive from an older setup run.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Rejects HTTP errors before caching native dependency archives.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "fix(build): keep HTTP errors out of the ..." · Reviewed by Greptile