Skip to content

fix(build): keep HTTP errors out of the setup archive cache - #2953

Open
AksharP5 wants to merge 1 commit into
CapSoftware:mainfrom
AksharP5:fix/setup-http-error-cache
Open

AksharP5 wants to merge 1 commit into
CapSoftware:mainfrom
AksharP5:fix/setup-http-error-cache

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

One temporary download-server error can leave cap-setup failing on every retry. It caches the HTTP error body as a native dependency archive and never downloads it again.

Check the HTTP status before reading bytes in the five unguarded download paths. Add a regression that executes the complete setup script with real HTTP and tar, and run it in Linux CI after the required desktop dependencies are installed.

Closes #2952.

Sequence Before After
Download returns 503 Error body cached; tar error HTTP 503; no archive written
Retry with healthy server Fails again without a request Setup succeeds
Warm-cache setup Blocked by poisoned archive Succeeds without requests

Validation: the new regression fails on main and passes with the fix. All eight setup/Linux bundle configuration tests pass, along with scoped Biome, Node syntax checks and CI YAML parsing. The fixture verifies staged library contents and generated configurations using synthetic library archives. Native macOS/Windows setup and application builds were not run locally.

This prevents new HTTP-error cache entries; it does not repair an already-poisoned archive from an older setup run.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Rejects HTTP errors before caching native dependency archives.

  • Setup downloads stop on HTTP errors before saving archives.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "fix(build): keep HTTP errors out of the ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A temporary HTTP error poisons the cap-setup archive cache and prevents retries

1 participant