Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizing long render-farm exports briefly blocks the coordinator and allocates hundreds of MiB for a small MP4 header. Write each sample-size table into one sized buffer, preserving the existing header bytes and chunk offsets.
Closes #2950.
Medians of five alternating fresh-process trials per case with production one-second media runs on Linux, i5-14400F, Bun 1.4.1. The two-hour case cuts header time by 92.6% and peak process RSS by 86.6%. RSS measures transient allocation pressure including the process runtime. The benchmark isolates header assembly; it does not measure total export speed. The linked issue contains the executable benchmark, ranges and baseline commit.
Validation: all 160 render-farm tests pass; sample-size assertions now cover both video and audio tables, asymmetric byte order and unsigned high bits. Scoped Biome and strict TypeScript checks pass. All benchmark headers match byte for byte. A complete four-second MP4 made from real H.264/AAC packets also matches byte for byte and decodes without errors: 240 video frames and 188 AAC frames. No live fleet or S3 deployment was run.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR reduces temporary allocations when building MP4 headers.
No actionable issues were found. Checks in this review were code-based; tests and benchmarks were not rerun.
Reviews (1) · Last reviewed commit: "perf(render-farm): cut peak memory durin..." · Reviewed by Greptile