[MinitJain]

Problem

In the custom domain dialog (org settings), once a domain is verified:

1. Clicking a completed step ("Domain" or "Verify") in the stepper jumps straight back to the success screen, so earlier steps can't be reviewed.
2. The 8s auto-close timer piles up: every bounce or parent re-render schedules another handleClose, and those timers keep firing after the dialog unmounts.

Root cause

A single effect handled both auto-advance and auto-close, with deps [isVerified, stepState.currentIndex, handleClose, handleNext]:

• With isVerified true, any step change that wasn't the success step called handleNext(). A stepper click (GO_TO_STEP) changed currentIndex, so the effect walked the user back to success.
• The setTimeout had no cleanup. handleClose depends on onClose, which CustomDomain.tsx passes inline, so every parent re-render re-ran the effect and added another timer.

Fix

Split into two effects:

• Auto-advance runs only when isVerified changes (GO_TO_STEP 2), so stepper navigation no longer re-triggers it.
• Auto-close depends only on currentIndex, reads the latest handleClose through a ref, and clears its timer on cleanup. There's one timer per visit to the success step, and it doesn't restart on parent re-renders.

The new hooks sit above the if (!currentStep) return null early return, which also clears Biome's useHookAtTopLevel warning that the old effect had.

How to reproduce

1. Org settings → Custom domain, with a verified domain. The dialog opens on the success step.
2. Click "Domain" in the stepper. Before: it bounces back to success. After: it stays on Domain.
3. Re-render the parent a few times while on success, or close the dialog. Before: several timers are live, and they still fire after unmount. After: exactly one timer, and none after unmount.

Tests

Two standalone repros, each rendering the real component with its boundary imports stubbed:

• Stepper bounce: before {"afterClickDomain":"success","timersAfter":2}, after {"afterClickDomain":"domain","timersAfter":1}.
• Timer leak: before {"afterRerenders":4,"afterUnmount":4}, after {"afterRerenders":1,"afterUnmount":0}.

Checks run locally:

• lint (Biome): pass
• typecheck: pass (no errors in this file)
• build: not run (next build needs the app's environment and services)

Confidence Score: 5/5

This PR appears safe to merge.

Summary

Separates verified-domain navigation from the dialog’s eight-second close timer.

• The verified dialog lets people revisit completed steps.
• The success step closes after one cancellable countdown.

_{Reviews (1) · Last reviewed commit: "fix(web): stop custom domain dialog boun..." · Reviewed by Greptile}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
cap-status	Skipped		Oct 22, 2026 6:59pm UTC