Repository navigation
fix(cli): find recordings in Desktop's custom storage folders - #2943
Conversation
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @AksharP5, reading the same custom and previous storage folders as the desktop app is the right fix, and the new tests run in Linux CI. One small follow-up from the Greptile review before we merge: the merge test in |
|
Addressed in 0dc4e74. Four fixtures now have fixed creation times interleaved across two folders, and the test asserts their exact newest-first order. It fails if ordering is reversed or the global sort is removed. All five production-module tests and scoped Clippy pass with the real project parser; an executable replay also confirms real-metadata ordering and exclusive --dir behavior. cargo fmt passes. The full CLI cargo check still stops at the existing local FFmpeg header mismatch, libavcodec/avfft.h missing. |
|
@greptileai review |
cap recordings listmisses recordings after changing Desktop's storage folder. It can return an empty library even though Desktop and an explicit--dirboth find the recording.Read Desktop's current and previous storage paths, include the default folder, and deduplicate equivalent roots before using the existing scanner. Automatically discovered unreadable folders are skipped, matching Desktop. Explicit
--dirstays exclusive and retains read errors. The combined list stays newest first.Closes #2942.
Before / after
The same generated MP4 recordings and isolated Desktop settings were used with the baseline and patched production listing modules.
[]Custom, withoutputExists: trueDefaultonly--dirpoints to custom storageCustomonlyCustomonlyValidation
--all-targets --no-deps -- -D warnings.--dir, and wired it and the five unit tests into Linux CI. Updated the command documentation.cargo fmt --all, README formatting, andgit diff --checkpass.cargo check -p cap --locked --offlinestops inffmpeg-sys-nextbecause the local FFmpeg headers lacklibavcodec/avfft.h. The full CLI integration test has not run locally.

Confidence Score: 5/5
The PR appears safe to merge; no blocking issues remain.Summary
Updates
cap recordings listto find recordings in Desktop's current, default, and previous storage folders.The earlier ordering-test concern is addressed: the test now supplies four fixed creation times across two folders and checks the exact returned order. No new actionable issues were found in the changes since the previous review. Tests were not run during this review.
Reviews (2) · Last reviewed commit: "test(cli): verify newest-first recording..." · Reviewed by Greptile