Repository navigation
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disk errors while assembling transcription audio currently produce uncaught stream errors even when the caller catches the helper's promise. That can escape the workflow's intended fallback to post-mux transcription.
The helper now uses Node's
pipeline()to consume the existing ordered download batches and handle output errors and completion. Two regression cases cover a pending-download output-open failure and a real LinuxENOSPCwrite. They run in the existing Recording Reliability workflow.Closes #2938
/dev/fullENOSPC, then an uncaught stream error; exit 1ENOSPC; exit 0ENOENTeventENOENTVerified against current main
1965b3179on Node 26.11.1. The Node checks also cover segment ordering, the concurrency bound, empty input, and HTTP failure details. Scoped Biome, strict helper typecheck with Node 20 declarations, workflow YAML parsing, and whitespace checks pass.The two repository regression tests also pass under Bun with a temporary Vitest import adapter. Full Vitest and the complete hosted workflow were not run locally because this isolated checkout has no installed application dependencies. No deployment crash is claimed. Fetch batching, the byte limit, returned byte count, and the buffer-based helper are unchanged.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Replaces manual stream writes with
pipeline()so disk errors reject the promise and reach the existing transcription fallback.Reviews (1) · Last reviewed commit: "fix(web): handle disk errors during tran..." · Reviewed by Greptile