Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2936 (Linear CAP-880)
Summary
When hovering over the timeline seek bar on a Cap share page (/s/[videoId]), the hover tooltip popup displays the chapter title and timestamp of the hovered position. However, \generateVideoFrameThumbnail\ previously discarded the hovered timestamp parameter (_time) and snapshot the live HTML5 <video>\ element (\�ideoRef.current).
Because <video>\ only holds decoded pixel data for its active \currentTime\ (the currently playing or paused frame), moving the mouse anywhere across the timeline always captured the active frame. This created a visual contradiction where the tooltip text described one chapter/timestamp (e.g., \11:07), but the thumbnail preview permanently showed the frame from an earlier/different part of the video (e.g., paused at \
The PR appears safe to merge.Summary
The player now hides live-frame thumbnails when the hovered time is more than 1.5 seconds from playback.
Reviews (1) · Last reviewed commit: "fix(web): prevent stale live video snaps..." · Reviewed by Greptile