Repository navigation
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A share timeline opened before media metadata can stay collapsed when the recording has no stored duration. Its first seek lands back at the start because duration changes are dropped while playback time remains zero.
The playback store now notifies subscribers when duration changes as well as time. Unchanged samples remain silent. Regression cases are included in the existing CI web test command.
Closes #2931
[0, 0][0, 2]Verified with 28 focused tests, strict TypeScript checks of the changed store and tests, scoped Biome, workflow YAML parsing, and native media comparisons in Chromium 152 and 154. Three regression cases fail on baseline
848d18fe7; all pass with the fix.The browser proof uses actual repository helpers and a synthetic muted clip. It does not mount the full Next.js share page or exercise an authenticated account. No dependencies or public API changed.


Confidence Score: 5/5
The PR appears safe to merge.Summary
The playback store now notifies subscribers when a finite video duration changes, even when playback time stays unchanged.
Review was based on source inspection; tests and browser checks were not run.
Reviews (1) · Last reviewed commit: "fix(web): update the timeline when video..." · Reviewed by Greptile