Skip to content

fix(web): update the timeline when video duration loads - #2932

Open
AksharP5 wants to merge 2 commits into
CapSoftware:mainfrom
AksharP5:fix/web-timeline-loaded-duration
Open

AksharP5 wants to merge 2 commits into
CapSoftware:mainfrom
AksharP5:fix/web-timeline-loaded-duration

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

A share timeline opened before media metadata can stay collapsed when the recording has no stored duration. Its first seek lands back at the start because duration changes are dropped while playback time remains zero.

The playback store now notifies subscribers when duration changes as well as time. Unchanged samples remain silent. Regression cases are included in the existing CI web test command.

Closes #2931

Same paused two-second clip, attached before metadata Before After
Duration observed by subscriber 0 seconds 2 seconds
Timeline window [0, 0] [0, 2]
First midpoint seek 0 seconds 1 second

Verified with 28 focused tests, strict TypeScript checks of the changed store and tests, scoped Biome, workflow YAML parsing, and native media comparisons in Chromium 152 and 154. Three regression cases fail on baseline 848d18fe7; all pass with the fix.

The browser proof uses actual repository helpers and a synthetic muted clip. It does not mount the full Next.js share page or exercise an authenticated account. No dependencies or public API changed.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The playback store now notifies subscribers when a finite video duration changes, even when playback time stays unchanged.

  • The share timeline learns video duration even when playback stays still.

Review was based on source inspection; tests and browser checks were not run.

Reviews (1) · Last reviewed commit: "fix(web): update the timeline when video..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timeline seek stays at the start when duration loads while paused

2 participants