Repository navigation
fix(verify): reject stale performance reports on reruns - #2930
Merged
richiemcilroy merged 5 commits intoOct 23, 2026
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local performance comparison rerun can pass using case reports left by an earlier run, even when the new binaries report no cases. It also overwrites the earlier logs.
Each invocation now requires a fresh report directory before opening its log or launching a child. The
--outhelp explains this requirement. Existing empty parent output directories still work. The regression tests run in the existing performance workflow's scope job.Closes #2929
test.logOriginal verification on baseline
848d18fe7with the actual Python CLI and subprocess fixtures implementing the native report contract. Three focused tests pass; the stale-report regression fails on baseline. The 31 adjacent report-diff tests, Python syntax/indentation checks, workflow YAML parsing and whitespace checks pass. The exact new CI test command also passes locally.No native media binaries were built or benchmarked. This corrects result isolation and makes no performance claim.
Branch refresh on 23 October 2026: merged main
a148d610e0af9725e4eba47e653ad4972d426bb3in379691dfd9312d8d46f5c9653a412fecfd47b9db, including #2785's crash-verification fix. The PR diff is unchanged.The three report-isolation tests and all 31 adjacent report-diff tests pass after the merge. Python syntax/indentation, workflow YAML/test wiring, and whitespace checks also pass. No native media build or benchmark was run locally.
On this head, both previously failing static-screen crash cases now pass. The macOS engine job reports a separate
crash/recorder-kill/oop/random0failure: six handed frames are missing before the last complete fragment ends. Its automatic retry passes, but CI deliberately keeps intermittent failures red. The real-capture job also reports screen/microphone sync of -11 ms against a -10 ms lower bound. The VideoToolbox job also reports an unexpected pass forexport/instant-gated-system-continuous-mic-late/output/mp4/native: measured microphone/system sync is +1.73 ms, while the case is still marked as an expected sync failure. This single run does not establish that the expectation can safely be removed. The final Engine verify and Verify recording failures summarize these platform results. These native paths are unchanged from the merged main revision. A targeted rerun request was denied because the GitHub integration lacks Actions write permission; these checks remain unresolved.

Confidence Score: 5/5
The PR appears safe to merge; the test rename and workflow command agree.Summary
The PR rejects existing report directories before opening logs or starting a child, preventing stale reports from passing a new comparison.
Reviews (2) · Last reviewed commit: "test(verify): use kebab-case for the per..." · Reviewed by Greptile