Repository navigation
Conversation
Contributor
|
@Addin is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
bun run builddies withSIGSEGV/SIGBUSat turbo's default concurrency. No build task is dying: turbo 2.10.2 segfaults while stopping the graph.On a task failure the default
--continue=nevercancels running tasks;ProcessManager::close(Stop)stops every child concurrently, and eachstop()callssysinfo::System::new_all(). On musl that refreshes the users list through non-reentrantgetpwuid/getgrgid, and two threads racing the shared statics corrupt the heap. The kernel log from a crashed run showstraps: tokio-rt-worker[...] general protection fault ... in turbo[...], with two workers faulting in the same run. Turbopack/vinxi/vite only exit 130 because turbo SIGINTs them.Fixed upstream in vercel/turborepo#13256, first released in 2.10.4. This raises turbo
^2.3.4→^2.11.10; the lockfile was the pin — the old range already allowed 2.11.10.Changes
package.json: turbo^2.3.4→^2.11.10bun.lock: turbo 2.10.2 → 2.11.10, plus the six@turbo/*platform packagesVerification
turbo run build --force×12tokio-rt-workertrapsbun run build(default concurrency)@cap/sdk-recorder#buildfailsbun install --frozen-lockfile→ no changesbun run check:bun→ 506 workspace dependencies match the lockfileturbo run build --dry-run=json→ 24 packages / 24 tasks, empty stderrturbo run dev,docker:up,test --dry=json→ exit 0turbo run test --filter=@cap/recorder-core→ 1 successfulOut of scope
bun run buildfails on@cap/sdk-recorderDTS — package is outside the typecheck graph #2915:@cap/sdk-recorderDTS error (PR fix(sdk-recorder): fix CapRecorder.on unsubscribe type error and add tsconfig reference #2917). It is the task failure that triggers the shutdown today; the build still exits 1 for it.apps/desktop/app.config.timestamp_*.jsbehind when a build is interrupted..envinglobalDependencies, deprecated--no-cacheindev:manual.Closes #2916


Confidence Score: 5/5
This PR appears safe to merge; no actionable issue was found.Summary
Updates
turboto address the reported crash when stopping build tasks.Reviews (1) · Last reviewed commit: "fix(build): upgrade turbo to 2.11.10" · Reviewed by Greptile