Repository navigation
fix(desktop-gpui): keep overlays under the pointer near preview edges - #2905
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dragging a text, image or mask overlay near the top or left edge of the preview made it jump inward away from the pointer. the drag clamped the overlay's top left corner into the frame before working out the centre, so anything that was allowed to hang off the left or top got pulled back, while the right and bottom edges were fine.
now only the final centre is clamped to the frame, same as before for the other edges, so overlays follow the pointer and can partly overhang on every side like keyboard nudges already allow. snapping is unchanged. tests drag near the edges on wide, tall and square previews.
This PR appears safe to merge.Summary
Changes
overlay_drag_centerto clamp only the final center, letting overlays hang past the top and left edges without jumping inward.Reviews (1) · Last reviewed commit: "fix(desktop-gpui): keep overlays under t..." · Reviewed by Greptile